GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Burkeholland-issue1635 by burkeholland · Pull Request #2993 · microsoft/vscode-pull-request-github

Conversation

@burkeholland

@burkeholland Burke Holland (burkeholland) commented Sep 10, 2021

Copy link
Copy Markdown
Collaborator

Fixes #1635

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burkeholland
Navigate from pull request query to settings json
f699c23 
Fixes #1635
@burkeholland
Burke Holland (burkeholland) requested a review from Alex Ross (alexr00) September 10, 2021 17:13
@burkeholland

Burke Holland (burkeholland) commented Sep 10, 2021

Copy link
Copy Markdown
Collaborator Author

I tried to do this as close to how it was done for the Issues, but the way the Issues TreeView is implemented seems quite different from the PR's. I'm guessing the PR's came first? In any event, this works the same way that the Issues edit query works if not implemented differently.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alexr00
Alex Ross (alexr00) requested changes Sep 22, 2021
View reviewed changes
Comment thread src/view/treeNodes/categoryNode.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@alexr00 Alex Ross (alexr00) added this to the October 2021 milestone Sep 29, 2021
@burkeholland
Reuse PR_SETTINGS_NAMESPACE
f299878
alexr00
Alex Ross (alexr00) approved these changes Oct 26, 2021
View reviewed changes

@alexr00 Alex Ross (alexr00) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alexr00
Alex Ross (alexr00) merged commit c7249ca into microsoft:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexr00 Alex Ross (alexr00) alexr00 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

October 2021

Development

Successfully merging this pull request may close these issues.

Navigate from pull request query to settings json

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@burkeholland @alexr00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.