GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow empty labels array to be pushed to set-labels to remove all of them by Balastrong · Pull Request #4637 · microsoft/vscode-pull-request-github

Conversation

@Balastrong

@Balastrong Leonardo Montini (Balastrong) commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

This PR fixes #4634

If there are no checked labels from the quick pick menu, the command set-labelsis not posted, preventing the possibility to remove all (the last one) selected labels.
I didn’t remove the if because labelsToAdd can be undefined if the menu is closed with esc, but the length control is causing the bug hence should be removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Balastrong
Allow empty labels array to be pushed to set-labels to remove all of …
9fea5e1 
…them
@alexr00 Alex Ross (alexr00) added this to the March 2023 milestone Mar 17, 2023
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) March 17, 2023 08:57
alexr00
Alex Ross (alexr00) approved these changes Mar 17, 2023
View reviewed changes

@alexr00 Alex Ross (alexr00) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Balastrong reacted with heart emoji
All reactions
  • ❤️ 1 reaction
ulugbekna
Ulugbek Abdullaev (ulugbekna) approved these changes Mar 17, 2023
View reviewed changes
@alexr00
Alex Ross (alexr00) merged commit 922df3d into microsoft:main Mar 17, 2023
@Balastrong
Leonardo Montini (Balastrong) deleted the fix/remove-last-label branch March 17, 2023 10:58
@Balastrong Leonardo Montini (Balastrong) mentioned this pull request Mar 20, 2023
Allow empty array to be pushed to remove the last label #4648
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulugbekna Ulugbek Abdullaev (ulugbekna) ulugbekna approved these changes
@alexr00 Alex Ross (alexr00) alexr00 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

March 2023

Development

Successfully merging this pull request may close these issues.

Cannot remove the last label

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Balastrong @ulugbekna @alexr00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.