GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cherry-pick Pipfile detection fix for 2018.2.1 by brettcannon · Pull Request #1002 · microsoft/vscode-python

Conversation

@brettcannon

@brettcannon Brett Cannon (brettcannon) commented Mar 9, 2018

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Will Thompson (wjt) and others added 2 commits March 9, 2018 09:39
@wjt @brettcannon
Detect pipenv by looking for Pipfile, not pipfile (microsoft#994)
06470be
On platforms with case-sensitive filesystems, like Linux, these are not
equivalent. pipenv documents that the file should be called Pipfile[0]
and `Pipfile.find()` only finds files matching this exact case[1].

As a result, even if `pipenv --venv` in `cwd` would return success, it
will never be run on Linux, and Code never detects the pipenv. (You can
work around this with `touch pipfile`.) With this change, it's detected
successfully. I believe there's no need to add a backwards-compatibility
check for the old case, because on platforms where the old, incorrect
check worked, so will the new, correct one.

[0] https://docs.pipenv.org/basics/#example-pipfile-pipfile-lock
[1] https://github.com/pypa/pipfile/blob/5acb9ac7/pipfile/api.py#L76-L85
@brettcannon
Prep for 2018.2.1
1bd76fa
@brettcannon
Brett Cannon (brettcannon) requested a review from Don Jayamanne (DonJayamanne) March 9, 2018 17:45
@codecov

codecov Bot commented Mar 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1002 into release-2018.2 will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2018.2    #1002      +/-   ##
==================================================
- Coverage           64.27%   63.99%   -0.28%     
==================================================
  Files                 260      260              
  Lines               12024    12024              
  Branches             2129     2129              
==================================================
- Hits                 7728     7695      -33     
- Misses               4287     4320      +33     
  Partials                9        9
Impacted Files Coverage Δ
...ent/interpreter/locators/services/pipEnvService.ts 68.08% <100%> (ø) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 33.33% <0%> (-20%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/linters/baseLinter.ts 85.41% <0%> (-6.25%) ⬇️
src/client/common/installer/productInstaller.ts 61.7% <0%> (-4.26%) ⬇️
...reter/locators/services/cacheableLocatorService.ts 91.83% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f777f6...1bd76fa. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DonJayamanne
Don Jayamanne (DonJayamanne) approved these changes Mar 9, 2018
View reviewed changes
@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 3008532 into microsoft:release-2018.2 Mar 9, 2018
@brettcannon
Brett Cannon (brettcannon) deleted the release-2018.2 branch August 9, 2018 23:57
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne Don Jayamanne (DonJayamanne) DonJayamanne approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brettcannon @DonJayamanne @wjt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.