GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set Content-Type explicitly in LargeFileUploadTask. by buptliuhs · Pull Request #502 · microsoftgraph/msgraph-sdk-javascript

Conversation

@buptliuhs

@buptliuhs Tony Liu (buptliuhs) commented Aug 14, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

In LargefileUploadTask, set Content-Type to application/octet-stream explicitly, otherwise application/json will be used by default, which is not correct.

Motivation

Although using the default application/json does not impact the functionality, if a client using the SDK has something like http-interceptor to examine the request payload, incorrect Content-Type can be misleading, for example, application/json suggests plain/text in json format.

Test plan

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@buptliuhs
Set Content-Type explicitly in LargeFileUploadTask.
0f2df40
@nikithauc

Nikitha Chettiar (nikithauc) commented Aug 14, 2021

Copy link
Copy Markdown
Contributor

Tony Liu (@buptliuhs) Thanks again for your contribution!!

I will review this next week.

Question for you, are you facing an error with the current code that is setting the default header to application/json ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@buptliuhs

Tony Liu (buptliuhs) commented Aug 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Nikitha Chettiar (@nikithauc) , No, files can be successfully uploaded even the header is set to application/json by default, so I guess the API server just doesn't check it. This is NOT actually impacting the file upload functionality.
However, as I mentioned, it is not uncommon, on the client-side, there is logic like http-interception doing things logs, audits, and etc. Having application/json in the header is misleading and can cause unexpected behaviours.
No unit test updated for now since the existing part of the code is not covered in any test cases. I can add some (of course need to do some refactoring to make it testable) if it is needed.
Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nikithauc Nikitha Chettiar (nikithauc) self-assigned this Aug 17, 2021
nikithauc
Nikitha Chettiar (nikithauc) approved these changes Aug 19, 2021
View reviewed changes
@nikithauc
Nikitha Chettiar (nikithauc) merged commit 6cbb558 into microsoftgraph:dev Aug 19, 2021
@nikithauc Nikitha Chettiar (nikithauc) mentioned this pull request Nov 15, 2021
Release 3.0.1 #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nikithauc Nikitha Chettiar (nikithauc) nikithauc approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nikithauc Nikitha Chettiar (nikithauc)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@buptliuhs @nikithauc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.