GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(samples): added secrets file and updated documentation by sjha2048 · Pull Request #517 · microsoftgraph/msgraph-sdk-javascript

Conversation

@sjha2048

@sjha2048 Sahil Jha (sjha2048) commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Summary

secrets.js didn't exist because it was added in gitignore, hence removed it from there and updated documentation for the same.

Closing issues

closes #516

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sahil
fix(samples): added secrets file and updated documentation
8a595c0
@ghost

Deleted user (ghost) commented Sep 27, 2021 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baywet
Vincent Biret (baywet) requested a review from Nikitha Chettiar (nikithauc) September 27, 2021 11:44
nikithauc
Nikitha Chettiar (nikithauc) approved these changes Sep 27, 2021
View reviewed changes
@nikithauc

Nikitha Chettiar (nikithauc) commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Sahil Jha (@sjha2048) Thank you for your contribution!
sjha2048 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nikithauc
Nikitha Chettiar (nikithauc) merged commit 22233e9 into microsoftgraph:dev Sep 28, 2021
@nikithauc Nikitha Chettiar (nikithauc) mentioned this pull request Nov 15, 2021
Release 3.0.1 #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nikithauc Nikitha Chettiar (nikithauc) nikithauc approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reference to sample secrets file which doesn't exist

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sjha2048 @nikithauc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.