GeezerVison is showing github.com — Support 'file description' in LargeFileUploadTask. by buptliuhs · Pull Request #533 · microsoftgraph/msgraph-sdk-javascript
Conversation
Summary
Support optional file description in LargeFileUploadTask
Motivation
As a user, I want to have the option to add a file description when uploading a file via the LargeFileUploadTask API.
Test plan
N/A.
Closing issues
N/A.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- I have read the CONTRIBUTING document.
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
No existing unit tests at this level are to be updated. Updated the sample code to reflect the change.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Tony Liu (@buptliuhs) Thanks again for your contribution! I appreciate your feedback and efforts helping to improve the library :)
|
buptliuhs reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.