GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(main): Exclude kiota-dom-export.txt from builds by Fryguy · Pull Request #1488 · microsoftgraph/msgraph-sdk-python

Conversation

@Fryguy

@Fryguy Jason Frey (Fryguy) commented May 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

kiota-dom-export.txt is not needed at runtime and is a very large file (~32MB), contributing to a bloated package.

Fixes #1287

Luis Ramos (@lramosvea) Please review. Note that I hadn't originally created this PR, because I was under the impression that this repository's content was auto-generated as I saw recent PRs from a bot updating these files.

I also wasn't sure if this was a chore or build or something else - let me know if you want it changed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sh-at-cs and emilburzo reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Fryguy
Jason Frey (Fryguy) requested a review from a team as a code owner May 19, 2026 18:27
@Fryguy
Jason Frey (Fryguy) force-pushed the exclude-kiota-dom-export branch from 8233b9c to 408ea94 Compare May 19, 2026 18:28
@Fryguy
chore: Exclude kiota-dom-export.txt from builds
f03a881 
kiota-dom-export.txt is not needed at runtime and is a very large file
(~32MB), contributing to a bloated package.
@Fryguy
Jason Frey (Fryguy) force-pushed the exclude-kiota-dom-export branch from 408ea94 to f03a881 Compare May 19, 2026 18:30
@Fryguy Jason Frey (Fryguy) changed the title Exclude kiota-dom-export.txt from builds chore(main): Exclude kiota-dom-export.txt from builds May 19, 2026
@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) requested a review from Copilot May 19, 2026 21:17
Copilot AI reviewed May 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reduces distribution/package size by excluding a large, non-runtime text artifact (kiota-dom-export.txt) from Flit packaging inputs (per #1287).

Changes:

  • Add Flit sdist exclusion for msgraph/generated/kiota-dom-export.txt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pyproject.toml
Comment on lines +47 to +48
[tool.flit.sdist]
exclude = ["msgraph/generated/kiota-dom-export.txt"]
Copilot started reviewing on behalf of Ramses Sanchez-Hernandez (ramsessanchez) May 19, 2026 21:25
View session
Copilot AI mentioned this pull request May 20, 2026
Exclude kiota-dom-export.txt from distributable artifacts by removing it from package sources #1498
Open
6 tasks done
@Fryguy

Jason Frey (Fryguy) commented May 20, 2026

Copy link
Copy Markdown
Author

I am not a python expert, so I don't know if Copilot's suggestions make sense. Please advise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fryguy Jason Frey (Fryguy) mentioned this pull request May 26, 2026
kiota-dom-export.txt is large and included in the released package #1287
Open
@Fryguy

Jason Frey (Fryguy) commented Sep 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Ramses Sanchez-Hernandez (@ramsessanchez) - can you please review? I'd like to get this one completed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kiota-dom-export.txt is large and included in the released package

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fryguy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.