GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix parsing error propagation in Streamable HTTP JSON responses by kele5555 · Pull Request #1150 · modelcontextprotocol/java-sdk

Conversation

@kele5555

@kele5555 kele5555 commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

An HTTP 200 response containing invalid JSON currently completes sendMessage before parsing the body. The later parsing error cannot reach the pending request, so initialization eventually reports a timeout.

This moves the success signal after JSON-RPC parsing. Parsing failures now retain their cause and reach the existing McpClientSession failure callback, which removes the pending request. Notifications keep their existing behavior.

The existing empty-response test was named and documented as a notification test but sent an initialize request. It now sends notifications/initialized.

Validation on Java 17, with both Jackson 2 and Jackson 3:

  • 82 related tests passed per profile, including 10 new regression cases.
  • The initial regression run failed on the original code for transport completion, pending-request failure, and initialization failure.
  • Tests cover malformed/empty/blank JSON, the parsing cause, pending cleanup before close, normal initialize/list/call, notifications, HTTP 503, connection refusal, and a real timeout.
  • Docker-based tests were not run successfully in this environment; the full suite is not claimed as verified.

Related: #685 concerns SSE comment parsing. This change addresses the application/json response branch.

AI-assisted implementation, submitted for human review.

Fixes #1147

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kele5555
Fix parsing error propagation in Streamable HTTP JSON responses
81909b6
@hpdkhoa hpdkhoa mentioned this pull request Oct 2, 2026
Stdio client stops processing responses after rejecting a malformed response #1157
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Streamable HTTP: invalid JSON response is reported as a timeout

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kele5555
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.