GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Fix race condition in `subscription/listen` by Kehrlann · Pull Request #1327 · modelcontextprotocol/java-sdk Conversation
Contributor
Under highly contentious load, there might be a race condition in subscription/listen. Every change broadcast before subscribing to the change feed is lost. Subscription happens on a thread, and writing to the wire happens in another thread. The So we need to ensure that:
This is mostly a test-harness fix rather than a real-world scenario.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUnder highly contentious load, there might be a race condition in subscription/listen. Every change broadcast before subscribing to the change feed is lost. Subscription happens on a thread, and writing to the wire happens in another thread. The `ack` might be fully written to the transport, and received by the client, before the changes are subscribed to. A test harness might fire a change right after the test client receives `ack`, but before the changes are subscribed to, and therefore the change is lost. So we need to ensure that: 1. Changes are subscribed to BEFORE the ack 2. But the ACK goes first in any case (and only once) This is mostly a test-harness fix rather than a real-world scenario. Signed-off-by: Daniel Garnier-Moiroux <[email protected]> subscription/listen
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |