GeezerVison is showing github.com — feat: handle SSE comment messages by tzolov · Pull Request #467 · modelcontextprotocol/java-sdk
Conversation
tzolov
commented
Aug 7, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
- Add support for ignoring SSE comment lines that start with ':'
- Add debug logging for comment line processing
Resolves #443
Add support for handling SSE comment messages starting with ":" in ResponseSubscribers
Motivation and Context
This change implements proper handling of Server-Sent Events (SSE) comment lines according to the SSE specification. SSE streams can contain comment lines that start with ":" which should be ignored during processing. Previously, these comment lines were not explicitly handled, which could lead to parsing issues or unexpected behavior when processing SSE streams.
How Has This Been Tested?
- Tested with SSE streams containing comment lines starting with ":"
- Verified that comment lines are properly ignored and logged at debug level
- Confirmed that normal SSE processing continues unaffected
Breaking Changes
No breaking changes. This is a backward-compatible enhancement that adds proper handling for SSE comment lines without affecting existing functionality.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to change)
- Documentation update
Checklist
- I have read the MCP Documentation
- My code follows the repository's style guidelines
- New and existing tests pass locally
- I have added appropriate error handling
- I have added or updated documentation as needed
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.