GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Completely drop `RootModel` from `types` module by Kludex · Pull Request #1910 · modelcontextprotocol/python-sdk

Conversation

@Kludex

@Kludex Kludex commented Jan 19, 2026

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Kludex added 3 commits January 18, 2026 21:48
@Kludex
Drop RootModel from JSONRPCMessage
04354dd
@Kludex
Drop RootModel from JSONRPCMessage
8e567ec
@Kludex
Completely drop RootModel from types module
cd4fcf2
Base automatically changed from drop-root to main January 19, 2026 13:04
@Kludex
Merge origin/main into drop-root-client-server-specific
0258a98 
Resolved merge conflicts keeping TypeAdapter-based validation
(drop RootModel approach) as intended by this branch:
- src/mcp/shared/session.py: Use TypeAdapter adapters
- src/mcp/types.py: Don't import RootModel
- tests/client/test_session.py: Use adapter.validate_python()
- tests/experimental/tasks/client/test_capabilities.py: Use adapter
- tests/test_types.py: Use client_request_adapter
maxisbey
maxisbey reviewed Jan 19, 2026
View reviewed changes
Comment thread src/mcp/server/fastmcp/utilities/func_metadata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Kludex added 2 commits January 19, 2026 14:19
@Kludex
add migration note
197e264
@Kludex
Enable ruff for https://docs.astral.sh/ruff/rules/banned-api
87326d6
maxisbey
maxisbey approved these changes Jan 19, 2026
View reviewed changes
@Kludex
Kludex merged commit 5fdd48a into main Jan 19, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Kludex
Kludex deleted the drop-root-client-server-specific branch January 19, 2026 13:29
@maxisbey maxisbey mentioned this pull request Jul 24, 2026
Type system complexity creating developer friction and maintenance overhead #837
Closed
@Kludex Kludex mentioned this pull request Sep 7, 2026
Replace RootModel wrappers with type aliases and TypeAdapter validation #3470
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxisbey maxisbey maxisbey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Kludex @maxisbey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.