GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — fix: keep the URL's query string when params are passed by lesnik512 · Pull Request #145 · modern-python/httpware Conversation
Member
ProblemA URL's own query string was silently dropped whenever params were sent:
The cause is upstream: Upstream status: pydantic/httpx2#905 is open, and fix PR pydantic/httpx2#966 has been open since 2026-05 without review. The original httpx maintainer treated the replace behaviour as intended (encode/httpx#3433). If #966 lands, this change still yields the same URL and the helper can be removed. Fix
Behaviour change
Tests
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionshttpx2 replaces a URL's query whenever params are sent, including client-level params (pydantic/httpx2#905). Fold the URL query into params in build_request, the per-verb methods and stream, for both clients. Precedence: client params < URL query < per-request params. Uh oh!
There was an error while loading. Please reload this page.
This was referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |