GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — docs: put the circuit breaker before AsyncTimeout; document rate-mode and event-loop behaviour by lesnik512 · Pull Request #178 · modern-python/httpware Conversation
Member
Composition orderThe recommended async order changes from to With With the breaker outside the timeout, the httpware
I checked the old behaviour against The order stays documented only. httpware still does not enforce it at construction. The sync order ( Updated: the Composition section and its example, the Full-stack demoThe demo engine modelled the old order: a timed-out operation was never recorded by the breaker. It now records one as a failure ( With that change the scenario told the wrong story. The 4s latency spike in phase 1 opened the breaker, which then stayed open or half-open through the brownout, so the "retry recovers transient errors" beat never happened and the "hard down" stop fired during phase 2. I swapped the first two phases. The incident now runs brownout (2 to 5s), latency spike (5 to 8s), then hard down (8 to 12s), and the walkthrough has a new stop where timeouts open the breaker. Traced in the browser: the breaker stays closed through the brownout, opens at 6.97s from expired deadlines, its probe fails during hard down (reopens at 10.03s), and it closes at 12.24s. The page and chain badge state the new order. No other demo combines a timeout with a breaker. ADR-0004, updated in placeIts argument against a slow-call rate was that Rate mode can open on a successIn rate mode, once the rolling window holds Clearer cross-loop error
Release notes (0.22.0)Not breaking.
Tests
No effect on the request path: only the error-path message string and docs changed.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |