GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — fix: capped responses keep elapsed, next_request and default_encoding; capped redirect and auth hops reuse their connection by lesnik512 · Pull Request #179 · modern-python/httpware Conversation
Member
What changedBoth fixes apply only when The rebuilt response keeps three attributesWith a cap, httpware reads the body under the cap and rebuilds the response with
All three are now copied with public httpx2 API: the Redirect and auth hops reuse their connectionUnder a cap, httpware follows redirects and runs the auth flow itself. It used to close each intermediate response (a redirect, a ADR-0009ADR-0009 said keeping Behaviour changes for the 0.22.0 release notes
Why not raise on an oversized hop bodyRaising Test evidenceEach fix was test-first, in both worlds:
On loopback the capped sync GET went from 3.78 ms to 2.46 ms, about what the uncapped path takes (2.37 ms).
PerformanceThe single-request capped path does about 0.4 µs more work: two attribute sets, one constructor argument, and a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…; capped redirect and auth hops reuse their connection Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |