Description

kringol

opened on Apr 13, 2018

Issue body actions

How to reproduce:

new ObjectMapper(new MessagePackFactory()).copy();

or just

new MessagePackFactory().copy();

Causes:

java.lang.NullPointerException
	at org.msgpack.jackson.dataformat.ExtensionTypeCustomDeserializers.<init>(ExtensionTypeCustomDeserializers.java:38)
	at org.msgpack.jackson.dataformat.MessagePackFactory.<init>(MessagePackFactory.java:61)
	at org.msgpack.jackson.dataformat.MessagePackFactory.copy(MessagePackFactory.java:147)
	at com.fasterxml.jackson.databind.ObjectMapper.<init>(ObjectMapper.java:499)
	at com.fasterxml.jackson.databind.ObjectMapper.copy(ObjectMapper.java:617)

Activity

1. komamitsu commented on Apr 14, 2018

   

   komamitsu

   on Apr 14, 2018

   Member

   More actions

   Ah, the test I wrote checked only the case that MessagePackFactory has ExtensionTypeCustomDeserializers...
   https://github.com/msgpack/msgpack-java/blob/develop/msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackFactoryTest.java#L69-L79

   This can be a workaround. But anyway I'll fix it soon.

   ObjectMapper copy = new ObjectMapper(new MessagePackFactory()
                            .setExtTypeCustomDesers(new ExtensionTypeCustomDeserializers())).copy();
   

   Thanks.
2. komamitsu

   closed this as completedin #471on Apr 14, 2018
3. komamitsu commented on Apr 15, 2018

   

   komamitsu

   on Apr 15, 2018

   Member

   More actions

   @kringol @mrniko Released the fix with 0.8.16.
4. kringol commented on Apr 16, 2018

   

   kringol

   on Apr 16, 2018

   Author

   More actions

   Awesome, thanks @komamitsu
   That was quick :)

Issue actions