GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move Jackson 3 JMH benchmarks into a separate unpublished project by komamitsu · Pull Request #1017 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Aug 12, 2026

Copy link
Copy Markdown
Member

Fixes a packaging problem I introduced in #987.

JmhPlugin adds jmh-core, jmh-generator-bytecode and jmh-generator-reflection to libraryDependencies without a configuration. Since #987 enabled it on msgpack-jackson3, which is published, those three become compile dependencies of org.msgpack.jackson3:jackson-dataformat-msgpack and are inherited by every consumer along with jopt-simple, commons-math3 and asm:

<dependency><groupId>org.openjdk.jmh</groupId><artifactId>jmh-core</artifactId><version>1.37</version></dependency>
<dependency><groupId>org.openjdk.jmh</groupId><artifactId>jmh-generator-bytecode</artifactId><version>1.37</version></dependency>
<dependency><groupId>org.openjdk.jmh</groupId><artifactId>jmh-generator-reflection</artifactId><version>1.37</version></dependency>

The released org.msgpack:jackson-dataformat-msgpack:0.9.11 POM has no such entries.

Fix

Move msgpack-jackson3/src/jmh into a new msgpack-jackson3-benchmark project with publish / skip := true that depends on msgpack-jackson3, and drop JmhPlugin from the published module. This is the layout sbt-jmh's README asks for, since the generator needs a project of its own and the benchmark subproject should not be published.

Verification

  • msgpack-jackson3/makePom: msgpack-core and jackson-databind are the only compile-scope dependencies left, alongside the usual test-scoped entries
  • msgpack-jackson3/libraryDependencies: no JMH at all
  • msgpack-jackson3-benchmark/Jmh/compile: generator processes 11 classes, compiles 29 generated sources
  • test: msgpack-core 193, msgpack-jackson 77, msgpack-jackson3 123
  • jcheckStyle, scalafmtCheckAll, scalafmtSbtCheck: clean

The benchmark project is aggregated into the root next to msgpack-jackson3. Note that src/jmh is not compiled by test in either layout, so CI does not verify the benchmarks build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@komamitsu
Move Jackson 3 JMH benchmarks into a separate unpublished project
feee211
JmhPlugin adds jmh-core, jmh-generator-bytecode and jmh-generator-reflection to
libraryDependencies without a configuration, so enabling it on msgpack-jackson3
published them as compile dependencies of jackson-dataformat-msgpack, inherited
by every consumer along with jopt-simple, commons-math3 and ASM. The released
org.msgpack:jackson-dataformat-msgpack POM has no such entries.

Move src/jmh into msgpack-jackson3-benchmark, which depends on msgpack-jackson3
and is not published. This is also how sbt-jmh recommends laying out benchmarks,
since the code generator needs a project of its own.
@komamitsu
komamitsu requested a lite review from Copilot August 12, 2026 11:57
Copilot started reviewing on behalf of komamitsu August 12, 2026 12:02
View session
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@komamitsu komamitsu mentioned this pull request Aug 12, 2026
Add Jackson 3 support as org.msgpack.jackson3:jackson-dataformat-msgpack #1012
Open
@xerial
xerial merged commit 32d1c71 into msgpack:jackson3-migration Aug 13, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@komamitsu @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.