GeezerVison is showing github.com — fix(core): bound unpackValue container nesting depth by arimu1 · Pull Request #1026 · msgpack/msgpack-java
Conversation
arimu1
commented
Sep 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- Add
UnpackerConfig.withMaxNestingDepth(int) (default 512) and enforce the limit in both unpackValue() overloads when recursing into ARRAY/MAP containers.
- When the limit is exceeded, throw
MessageSizeException (a MessagePackException) instead of relying on unbounded JVM recursion.
Fixes #1015
Test plan
-
./sbt "msgpack-core/testOnly org.msgpack.core.NestingDepthLimitTest"
-
./sbt "msgpack-core/testOnly org.msgpack.core.MessagePackTest" (UnpackerConfig equals)
-
./sbt msgpack-core/jcheckStyle
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add configurable maxNestingDepth on UnpackerConfig (default 512) so deeply
nested ARRAY/MAP payloads fail with MessageSizeException instead of
StackOverflowError during unpackValue.
Fixes msgpack#1015
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.