GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Mimic SequenceInputStream interface more in SequenceMessageBufferInput by frsyuki · Pull Request #389 · msgpack/msgpack-java

Conversation

@frsyuki

@frsyuki frsyuki commented Sep 23, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary.

A reason is that behavior of SequenceMessageBufferInput.close (which is same withSequenceInputStream.close) is surprising, in my opinion. I expect that it closes input sequence without reading buffers. But they consume all of them. However, change of the behavior is also surprising because its behavior becomes inconsistent from SequenceInputStream.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@frsyuki
Mimic SequenceInputStream interface more in SequenceMessageBufferInput
00687cc
@frsyuki

frsyuki commented Sep 23, 2016

Copy link
Copy Markdown
Member Author

well, rather better idea is to move SequenceMessageBufferInput to test package. I think there're little demand for it. How do you think, @xerial?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xerial

xerial commented Sep 23, 2016

Copy link
Copy Markdown
Member

@frsyuki Just move it to test package. I think there will be no handy way to close a sequence of streams while managing there lifecycle.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frsyuki frsyuki mentioned this pull request Sep 30, 2016
move SequenceMessageBufferInput to test package #393
Merged
@xerial xerial closed this Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@frsyuki @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.