GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Jackson typebase ext deser by komamitsu · Pull Request #408 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Jan 18, 2017

Copy link
Copy Markdown
Member

For #398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
komamitsu added 2 commits January 12, 2017 00:33
@komamitsu
Override MessagePackExtensionType#equals and hashCode
a4b0f3f 
Also, added an unit test of deserialization of
MessagePackExtensionType based on type.
@komamitsu
Add MessagePackExtensionType.TypeBasedDeserializer
4112c0e
@komamitsu

komamitsu commented Jan 19, 2017

Copy link
Copy Markdown
Member Author

Hmm. This implementation works in ObjectMapper#readValue but doesn't work in ObjectMapper#readTree because ObjectMapper#_readMapAndClose runs with ObjectMapper#JSON_NODE_TYPE through ObjectMapper#readTree. In that case, MessagePackExtensionType.TypeBasedDeserializer isn't called at all...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu
Add MessagePackFactory#setExtTypeCustomDesers
473268e
@komamitsu
komamitsu merged commit 347b5e5 into develop Jan 25, 2017
@komamitsu
komamitsu deleted the jackson-typebase-ext-deser branch January 25, 2017 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@komamitsu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.