GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Avoid using CharsetEncoder of Android 4.x by komamitsu · Pull Request #409 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Jan 21, 2017

Copy link
Copy Markdown
Member

Android 4.x has a bug in CharsetEncoder where offset calculation is
wrong.
See

  • java.lang.IllegalArgumentException: Bad position on Android 4.x #405
  • Long strings are truncated on packing on Android 4.x #406

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@komamitsu
Avoid using CharsetEncoder of Android 4.x
f536c93 
Android 4.x has a bug in CharsetEncoder where offset calculation is
wrong.
See
- #405
- #406
@komamitsu

komamitsu commented Jan 21, 2017

Copy link
Copy Markdown
Member Author

@frsyuki Can you review this change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frsyuki

frsyuki commented Jan 23, 2017

Copy link
Copy Markdown
Member

LGTM 👍
Nice improvement. Please merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu

komamitsu commented Jan 23, 2017

Copy link
Copy Markdown
Member Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu
komamitsu merged commit 7f49d93 into develop Jan 23, 2017
@komamitsu
komamitsu deleted the android4-pack-string branch January 23, 2017 08:29
This was referenced Jan 25, 2017
Long strings are truncated on packing on Android 4.x #406
Closed
java.lang.IllegalArgumentException: Bad position on Android 4.x #405
Closed
@paddybyers paddybyers mentioned this pull request Jan 25, 2017
Msgpack truncates data member ably/ably-pubsub-java#261
Closed
@dbrgn

dbrgn commented Feb 16, 2017

Copy link
Copy Markdown

Is a release containing this fix planned soon? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu

komamitsu commented Feb 19, 2017

Copy link
Copy Markdown
Member Author

@dbrgn Released 0.8.12 that contains this fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dbrgn

dbrgn commented Feb 19, 2017

Copy link
Copy Markdown

@komamitsu Thanks a lot!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@komamitsu @frsyuki @dbrgn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.