GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix a bug ChannelBufferInput#next blocks until the buffer is filled by komamitsu · Pull Request #428 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Jun 22, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@komamitsu komamitsu mentioned this pull request Jun 22, 2017
ChannelBufferInput blocks until full buffer is read #426
Closed
@komamitsu komamitsu changed the title [WIP] Fix a bug ChannelBufferInput#next blocks until the buffer is filled Fix a bug ChannelBufferInput#next blocks until the buffer is filled Jun 24, 2017
@komamitsu

komamitsu commented Jun 24, 2017

Copy link
Copy Markdown
Member Author

@xerial Can you take a look at this pull request?

This pull request handles #426. The example code on the issue 426 actually includes the wrong usages (e.g. read/write a byte array without MessagePack header). But the issue itself can be reproduced with a test code this pull request includes.

BTW, the CI test for JDK9 on Travis CI isn't working https://travis-ci.org/msgpack/msgpack-java/jobs/246543240#L662. I have no idea about the error.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu
komamitsu requested a review from xerial June 24, 2017 13:32
@komamitsu

komamitsu commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

@xerial (cc: @frsyuki ) Kindly ping
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
komamitsu added 4 commits July 4, 2017 12:49
@komamitsu
Fix a bug ChannelBufferInput#next blocks until the buffer is filled
60ddba3
@komamitsu
Don't need to consider the case ReadableByteChannel#read returns 0
c52d806 
since the buffer size must be more than 0
@komamitsu
Add a unit test
323a5c3
@komamitsu
Remove unused imports
fdddf49
@komamitsu
komamitsu force-pushed the fix-issue-426 branch from f1cd8e6 to fdddf49 Compare July 4, 2017 03:50
@komamitsu

komamitsu commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

BTW, the CI test for JDK9 on Travis CI isn't working https://travis-ci.org/msgpack/msgpack-java/jobs/246543240#L662. I have no idea about the error.

#429 handled this problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xerial

xerial commented Jul 11, 2017

Copy link
Copy Markdown
Member

@komamitsu Nice catch. Thanks for the fix. This LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xerial
xerial merged commit 81d540d into develop Jul 11, 2017
@komamitsu
komamitsu deleted the fix-issue-426 branch July 12, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xerial xerial Awaiting requested review from xerial

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@komamitsu @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.