GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove "-target:jvm-1.7" from scalacOptions by xuwei-k · Pull Request #456 · msgpack/msgpack-java

Conversation

@xuwei-k

@xuwei-k xuwei-k commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

Scala 2.12 does not support "-target:jvm-1.7"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@xuwei-k
remove "-target:jvm-1.7" from scalacOptions
9500d21
Scala 2.12 does not support "-target:jvm-1.7"
@xerial

xerial commented Feb 7, 2018

Copy link
Copy Markdown
Member

OK. Then we need to drop java7 support totally in upcoming version.

@komamitsu @frsyuki
Should we bump the version number to 0.9.x before dropping Java7 support?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xuwei-k

xuwei-k commented Feb 8, 2018

Copy link
Copy Markdown
Contributor Author

msgpack-java already use sbt 1.x (which does not support Java 7)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xerial

xerial commented Feb 8, 2018

Copy link
Copy Markdown
Member

@xuwei-k I'm not sure how sbt handles target:jvm-1.7 option, but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

javap -cp . -v "org.msgpack.core.MessagePack" | grep version                                                                     [11:24:44 Feb 07 2018]
  minor version: 0
  major version: 51
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xuwei-k

xuwei-k commented Feb 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

Yes, sbt 1.x can generate JVM7 byte code from Java sources. but sbt 1.x and Scala 2.12 compiler does not run on JVM 7.
This pull request changes scalacOptions not javacOptions. scalacOptions is different from javacOptions.
This change has no effect (just suppress warnings) because Scala 2.12 compiler says follows when set -target:jvm-1.7

[warn] -target is deprecated: -target:jvm-1.7 is deprecated, forcing use of jvm-1.8
xerial reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xerial

xerial commented Feb 9, 2018

Copy link
Copy Markdown
Member

@xuwei-k Thanks for making it clear. I got confused scalacOptions and javacOptions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xerial
xerial merged commit 33ce348 into msgpack:develop Feb 9, 2018
@xerial

xerial commented Feb 9, 2018

Copy link
Copy Markdown
Member

Merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xuwei-k
xuwei-k deleted the patch-1 branch February 9, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xuwei-k @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.