GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fixes #544: Fix a bug in reading EXT32 with 2GB size by xerial · Pull Request #545 · msgpack/msgpack-java

Conversation

xerial commented Feb 14, 2021

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fixes #544: Fix a bug in reading EXT32 with 2GB size

f5ca68f

xerial requested a review from komamitsu

February 14, 2021 20:38

komamitsu reviewed

Feb 15, 2021

View reviewed changes

Comment thread

msgpack-core/src/test/scala/org/msgpack/core/InvalidDataReadTest.scala

		val msgpack = createMessagePackData(p => p.packExtensionTypeHeader(MessagePack.Code.EXT32, Int.MaxValue))
		val u = MessagePack.newDefaultUnpacker(msgpack)
		try {
		intercept[MessageInsufficientBufferException] {

komamitsu Feb 15, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expectation of this test case is unclear to me. I guess you want to avoid 2GB memory allocation in this test, though. How about adding a comment to describe your intention?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

xerial Feb 15, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comment to explain why we need to use this a bit weird test code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add comment

a04ddb5

komamitsu approved these changes

Feb 16, 2021

View reviewed changes

komamitsu left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

xerial merged commit f67b6e5 into develop

Feb 16, 2021

xerial deleted the skippayload-boundary-check branch

July 19, 2025 16:34

Reviewers

komamitsu

komamitsu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.