GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #542: Add a warning note for the usage of MessageUnpacker.readPayloadAsReference by xerial · Pull Request #546 · msgpack/msgpack-java

Conversation

@xerial

@xerial xerial commented Feb 14, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xerial
msgpack#542: Add a warning note for the usage of MessageUnpacker.read…
367fd7b 
…PayloadAsReference
@xerial xerial mentioned this pull request Feb 14, 2021
MessageBuffer allows unsafe out-of-bounds reads and writes #542
Open
@xerial
xerial requested a review from komamitsu February 14, 2021 22:16
komamitsu
komamitsu approved these changes Feb 15, 2021
View reviewed changes

@komamitsu komamitsu left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user of this method can know the buffer length encoded in the header. Even with a wrong length in header encoded by an attacker, it should be safe as long as the user of this method implements safely.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xerial
xerial merged commit 4976b7f into msgpack:develop Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@komamitsu komamitsu komamitsu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xerial @komamitsu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.