GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Prevent having two different unpacking methods by cyberdelia · Pull Request #548 · msgpack/msgpack-java

Conversation

@cyberdelia

@cyberdelia cyberdelia commented May 11, 2021

Copy link
Copy Markdown
Contributor

Prevent having two different unpacking methods in the unpacker: unpackValue exclusively use arrays for both arrays and maps , and unpackValue(Variable) uses list and map. This will prevent having two different behaviour when unpacking values and prevent some code duplication.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cyberdelia
Prevent having two different unpacking methods
b7e7806
xerial
xerial reviewed May 11, 2021
View reviewed changes
Comment thread msgpack-core/src/main/java/org/msgpack/core/MessageUnpacker.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
xerial
xerial reviewed May 11, 2021
View reviewed changes
Comment thread msgpack-core/src/main/java/org/msgpack/value/Variable.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cyberdelia
Fix loop
f48faa0
@xerial
xerial merged commit 75d33d1 into msgpack:develop May 11, 2021
@cyberdelia

cyberdelia commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

Well, I'm still worried by the lack of tests failing because of my improper logic copy/pasta.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cyberdelia
cyberdelia deleted the no-map-land branch May 11, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xerial xerial xerial left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cyberdelia @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.