GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java

Conversation

@xerial

@xerial xerial commented Jun 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

To use JDK17 + DirectByteBuffer, we need to set two JVM options:

--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED

This PR adds:

  • CI for JDK17
  • Add a workaround even if these JVM options are not set.
  • Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options

Related approaches:

  • [SPARK-36704][CORE] Expand exception handling to more Java 9 cases where reflection is limited at runtime, when reflecting to manage DirectByteBuffer settings apache/spark#33947
  • [SPARK-36796][BUILD][CORE][SQL] Pass all sql/core and dependent modules UTs with JDK 17 except one case in postgreSQL/text.sql apache/spark#34153 (--add-open JVM options to use reflection access)
  • Use DirectBuffer interface to get buffer address airlift/slice#130

Fixes #600

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AcumenDev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
xerial added 2 commits June 28, 2022 17:21
@xerial
Reproduce #600 (JDk17 error)
65188ed
@xerial
Add workaround for Java17
3dc7e9d
@xerial
xerial marked this pull request as ready for review June 28, 2022 09:28
xerial added 2 commits June 28, 2022 18:35
@xerial
Add a helpful error message
fdb537a
@xerial
Add note on JDK17
ecb4951
@xerial
xerial merged commit 117f161 into develop Jun 28, 2022
@xerial xerial mentioned this pull request Jun 28, 2022
Illegal reflective access by org.msgpack.core.buffer.DirectBufferAccess #605
Open
@akudiyar akudiyar mentioned this pull request Jan 2, 2024
Illegal access to msgpack.core.buffer.DirectBufferAccess tarantool/cartridge-java#452
Closed
@xerial
xerial deleted the jdk17-support branch July 19, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not working in 17 JDK

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.