GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate from JUnit 4 to JUnit 5 to resolve deprecation warnings by xerial · Pull Request #897 · msgpack/msgpack-java

Conversation

@xerial

@xerial xerial commented Jul 19, 2025

Copy link
Copy Markdown
Member

Summary

  • Migrates msgpack-jackson tests from JUnit 4 to JUnit 5
  • Resolves all JUnit deprecation warnings
  • Maintains test functionality and backward compatibility

Changes Made

  • Dependencies: Updated build.sbt to use JUnit 5 Jupiter and Vintage engines
  • Imports: Replaced JUnit 4 imports with JUnit 5 equivalents
  • Annotations:
    • @Test → @Test (JUnit 5)
    • @Before → @BeforeEach
    • @Test(expected=Exception.class) → assertThrows(Exception.class, () -> {...})
  • Assertions: Replaced deprecated org.junit.Assert.assertThat with org.hamcrest.MatcherAssert.assertThat

Test Results

✅ All tests pass successfully
✅ No more JUnit deprecation warnings
✅ Compilation successful

Backward Compatibility

The JUnit Vintage engine is included to maintain compatibility with any remaining JUnit 4 tests.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@xerial @claude
Migrate from JUnit 4 to JUnit 5 to resolve deprecation warnings
83bc36f
- Update build.sbt to use JUnit 5 dependencies (jupiter + vintage)
- Replace JUnit 4 imports with JUnit 5 equivalents
- Convert @test(expected=Exception.class) to assertThrows()
- Update @before to @beforeeach annotation
- Replace deprecated org.junit.Assert.assertThat with Hamcrest assertThat
- Maintain backward compatibility with JUnit Vintage engine

Fixes all JUnit deprecation warnings in msgpack-jackson tests.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@xerial
xerial merged commit 7367653 into main Jul 19, 2025
@xerial
xerial deleted the fix-junit branch July 19, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.