GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix Jackson deprecation warnings in MessagePackFactory by xerial · Pull Request #903 · msgpack/msgpack-java

Conversation

xerial commented Jul 19, 2025

Copy link

Copy Markdown

Member

Summary

Replace deprecated _createContext(Object, boolean) calls with _createContext(ContentReference, boolean)
Add missing import for ContentReference class
Eliminates deprecation warnings when running tests with Jackson 2.18.4

Test plan

Run sbt test and verify no Jackson deprecation warnings appear
Verify all existing tests continue to pass
Confirm Jackson module functionality remains unchanged

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix Jackson deprecation warnings in MessagePackFactory

f453da8

Replace deprecated _createContext(Object, boolean) calls with
_createContext(ContentReference, boolean) to eliminate warnings
when running tests with Jackson 2.18.4.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

github-actions Bot added the bug label

Jul 19, 2025

xerial and others added 2 commits

July 19, 2025 11:26


          Fix Jackson deprecation warnings in MessagePackParserTest

Replace deprecated JsonParser methods with their current equivalents:
- getCurrentName() → currentName()
- getTokenLocation() → currentTokenLocation()
- getCurrentLocation() → currentLocation()

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>


          Fix all remaining Jackson deprecation warnings

48271bd

- Replace deprecated ParserMinimalBase constructor with StreamReadConstraints
- Add non-deprecated location methods (currentTokenLocation, currentLocation)
- Update GeneratorBase constructor to use 4-parameter form with IOContext and JsonWriteContext
- Add new createKeySerializer method signature for Jackson 2.18
- Keep deprecated methods for backward compatibility

All tests pass and Jackson deprecation warnings are eliminated.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

xerial merged commit 799e2d1 into main

Jul 19, 2025

xerial deleted the fix-jackson-deprecation-warnings branch

July 19, 2025 19:40

This was referenced Jul 28, 2026

Add Jackson 3 support as org.msgpack.jackson3:jackson-dataformat-msgpack #1012

Open

Add msgpack-jackson3 module for Jackson 3.x support #987

Closed

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.