GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add module name to the package manifest attributes by thatcomputerguy0101 · Pull Request #986 · msgpack/msgpack-java

Conversation

@thatcomputerguy0101

@thatcomputerguy0101 thatcomputerguy0101 commented May 27, 2026

Copy link
Copy Markdown

I tried pulling msgpack-core in through Maven, and I noticed that the module name was being parsed from the jar file name as msgpack.core instead of org.msgpack.core. This change adds the module name defined in the sbt config to the package manifest attributes so that Maven autodetects the correct name.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thatcomputerguy0101
Add module name to the package manifest attributes
76f7696
@thatcomputerguy0101

thatcomputerguy0101 commented May 27, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

(PS: I'm not very familiar with sbt, so there may be a better way to do this.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatcomputerguy0101

thatcomputerguy0101 commented May 27, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Actually, I failed to test my final revision of this properly, so this doesn't work right now. I think it is fixed now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatcomputerguy0101
thatcomputerguy0101 marked this pull request as draft May 27, 2026 02:52
@thatcomputerguy0101
Move module name modification and change to root package export
b0adb4c 
`-` is not a vaild character for module names
@thatcomputerguy0101
thatcomputerguy0101 marked this pull request as ready for review May 27, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@thatcomputerguy0101
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.