GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reuse Encoder/Decoder instance by buu700 · Pull Request #177 · msgpack/msgpack-javascript

Conversation

@buu700

@buu700 buu700 commented May 5, 2021

Copy link
Copy Markdown

Addresses #172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@buu700
buu700 force-pushed the encoder-instance-reuse branch from d338d94 to 381f7e0 Compare May 5, 2021 00:24
@gfx

gfx commented May 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thank you for the contribution. We need to make sure it's safe when we use this PR in the async/await context.
buu700 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gfx

gfx commented May 5, 2021

Copy link
Copy Markdown
Member

Ah, right. It only changes the synchronous functions, although CI failed. It looks good.

Could you take a look at CI failure? I'll merge this PR if CI passes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@buu700
encode/decode minor performance optimization
252ea39 
msgpack#172
@buu700
buu700 force-pushed the encoder-instance-reuse branch from 381f7e0 to 252ea39 Compare May 5, 2021 01:39
@buu700

buu700 commented May 5, 2021

Copy link
Copy Markdown
Author

Cool, sounds good. I'll investigate the failure as soon as I have a moment, but just rebased on the tip of main in case that makes a difference.
gfx reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@buu700 @gfx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.