GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(decode): preserve mapKeyConverter in Decoder#clone() by maximilliangrand · Pull Request #295 · msgpack/msgpack-javascript

Conversation

@maximilliangrand

@maximilliangrand maximilliangrand commented Aug 16, 2026

Copy link
Copy Markdown

Problem

Decoder#clone() is used for re-entrant decoding — for example an extension codec that decodes nested MessagePack on the same reusable Decoder instance (the pattern from #195). clone() copies every decoder option except mapKeyConverter, so any map decoded re-entrantly silently falls back to the default key converter instead of the one the caller configured.

Repro (converter upper-cases keys; extension type 1 re-enters the same decoder):

const decoder = new Decoder({ extensionCodec, mapKeyConverter: (k) => String(k).toUpperCase() });
// extension type 1 decode: (data) => new Wrapped(decoder.decode(data))
const out = decoder.decode(encoder.encode({ a: 1, nested: new Wrapped({ b: 2 }) }));
// top-level keys: ["A", "NESTED"]   (converter applied)
// out.NESTED.inner keys: ["b"]      (converter dropped — should be ["B"])

Fix

Copy mapKeyConverter in clone() alongside the other options (keyDecoder and the max* limits are already copied). One line, plus a regression test that decodes a nested map through an extension codec.

Full suite: 328 passing; lint and typecheck clean.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@maximilliangrand
fix(decode): preserve mapKeyConverter in Decoder#clone()
a6b6c32
Decoder#clone() is used for re-entrant decoding (e.g. an extension codec
that decodes nested MessagePack on the same Decoder instance, issue msgpack#195).
It copied every decoder option except mapKeyConverter, so any map decoded
re-entrantly silently fell back to the default key converter instead of the
one the caller configured.

Copy mapKeyConverter in clone() alongside the other options, and add a
regression test that decodes a nested map through an extension codec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@maximilliangrand
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.