GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: reject streams ending with incomplete records by HocVoNgThai · Pull Request #300 · msgpack/msgpack-javascript

Conversation

@HocVoNgThai

@HocVoNgThai HocVoNgThai commented Oct 31, 2026

Copy link
Copy Markdown

Check for remaining array items, a pending value header or an unfinished container when an async decoding stream ends. Throw RangeError instead of reporting successful completion with missing records.

For example, a stream containing [{ id: 1 }, { id: 2 }] with its last byte missing currently finishes and returns only { id: 1 }. With this change, it still yields the complete first item, then rejects when it detects that the second item is incomplete. Complete streams retain their current behavior.

Adds regressions for array streams missing a whole item or part of its value, plus multi-record streams ending inside a string or nested object.

Closes #299

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@HocVoNgThai
fix: reject streams ending with incomplete records
5b32d41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stream decoders silently accept incomplete final records

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@HocVoNgThai
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.