GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix object reference key collision in msgpack_var_add by LaurinKerkloh · Pull Request #192 · msgpack/msgpack-php

Conversation

@LaurinKerkloh

@LaurinKerkloh LaurinKerkloh commented Oct 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Objects were keyed by a mix of class entry pointer and handle, which is not unique: two objects of different classes could share a key, so one was packed as a back-reference to the other.

Key objects by their zend_object address in a separate key space from arrays, and hold a reference to each packed object until packing ends so its address cannot be reused (as ext/standard/var.c does).

Fixes #191

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andypost reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@LaurinKerkloh
Fix object reference key collision in msgpack_var_add
d8eba36 
Objects were keyed by a mix of class entry pointer and handle, which
is not unique: two objects of different classes could share a key,
so one was packed as a back-reference to the other.

Key objects by their zend_object address in a separate key space
from arrays, and hold a reference to each packed object until
packing ends so its address cannot be reused (as ext/standard/var.c
does).
@LaurinKerkloh
LaurinKerkloh force-pushed the fix-var-hash-collision branch from 745e454 to d8eba36 Compare October 5, 2026 07:59
@andypost

andypost commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

It's the bigger fix: it silently corrupts data on 32-bit. solved a trick with #193 to build on x86/armhf

ref https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/111139
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andypost andypost mentioned this pull request Nov 4, 2026
Fix uint64 to float bound on 32-bit (1L<<52 is UB) #194
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Object reference table key collision: an object is packed as a back-reference to a different object

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@LaurinKerkloh @andypost
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.