GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fallback: count buffer bytes independently of memoryview shape by zhechen-cs · Pull Request #753 · msgpack/msgpack-python

Conversation

@zhechen-cs

@zhechen-cs zhechen-cs commented Oct 17, 2026

Copy link
Copy Markdown

The fallback sizes its unpackb limits with len(packed) and checks incoming feeds with len(view). For a multidimensional memoryview, that is the first dimension rather than the byte count. A six-byte message reshaped to (2, 3) fails to unpack with a spurious length error, while feeding it can exceed max_buffer_size without raising BufferFull. A zero-dimensional view raises TypeError on Python 3.12.

Normalize input to a contiguous, one-dimensional byte view before computing lengths. Contiguous input is cast without copying; non-contiguous input uses the byte copy already needed by feed. Decoding remains unchanged. Tests cover several shapes, non-contiguous multidimensional input, scalar views, exact-fit feeds, and preserving the stream after an oversized feed is rejected.

Validation on macOS arm64, CPython 3.12:

  • All six new cases fail on the unmodified fallback and pass on the unmodified C extension.
  • After the fix: fallback full suite 148 passed, 4 skipped; C extension full suite 151 passed, 1 skipped.
  • PyPy 3.11: 138 passed, 5 skipped with test/test_except.py excluded. That unchanged module cannot be collected because this PyPy build does not provide _tracemalloc.
  • Ruff lint and format checks, and git diff --check, pass.

The existing thread_unsafe marker warning also occurs on the base. Other platforms have not been tested locally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zhechen-cs
fallback: normalize buffer views before counting bytes
dcbfb71

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@zhechen-cs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.