GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add EnableObject by cielavenir · Pull Request #148 · mujin/controllerclientcpp

Conversation

@cielavenir

@cielavenir cielavenir commented Feb 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

  • Adds EnableObject and EnableLink APIs. A customer needs them to reset itl state partially. Corresponding tasks are already implemented in our planningcommon.

    • But we should add the API to master to avoid the name collision in the future.

  • Grab/Release json had trailing commas. ujson.loads() seems ignoring them, but let's fix them as well. fixed by Fix JSON strings #159

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cielavenir added 3 commits February 8, 2024 20:21
@cielavenir
Add EnableObject API
54f3faf
@cielavenir
incr timeout
62dfb43
@cielavenir
timeout
c5624d8
@cielavenir
cielavenir requested review from kanbouchou and rdiankov February 8, 2024 12:35
@cielavenir

cielavenir commented Feb 28, 2024

Copy link
Copy Markdown
Contributor Author

@kanbouchou any comments? or could you approve?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cielavenir added 2 commits March 12, 2024 10:08
@cielavenir
Merge remote-tracking branch 'origin/master' into AddEnableObject
f943564
@cielavenir
fix typo
b8449f4
@cielavenir

cielavenir commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

b8449f4 was pointed out by the customer. we would need to have better review process. /cc @ntohge @ziyan
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cielavenir
Merge branch 'master' into AddEnableObject
06bc39e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdiankov rdiankov Awaiting requested review from rdiankov
@kanbouchou kanbouchou Awaiting requested review from kanbouchou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@cielavenir
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.