GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — not encode filename when uploading by cielavenir · Pull Request #79 · mujin/controllerclientcpp

Conversation

@cielavenir

@cielavenir cielavenir commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

because filename field must not be encoded. I checked the behavior by clientpy experiments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cielavenir
not encode filename when uploading
08b902a
@cielavenir

cielavenir commented Oct 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

keeping unassigned intentionally until webstack1 one is merged.

webstack2 still has the issue

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rdiankov

rdiankov commented Apr 26, 2022

Copy link
Copy Markdown
Member

@ziyan can you comment with respect to new webstack?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ziyan
ziyan marked this pull request as draft April 27, 2022 04:54
@ziyan

ziyan commented Apr 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We use https://pkg.go.dev/mime/multipart#Part.FileName which internally uses https://pkg.go.dev/mime#ParseMediaType and it does not expec the filename part ot be encoded.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ziyan

ziyan commented Apr 27, 2022

Copy link
Copy Markdown
Member

Additionally, we also support ?filename= in url and filename filed in the multipart form body.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cielavenir
Merge remote-tracking branch 'origin/master' into notEncodeFilenameWh…
f15f018
…enUploading
@cielavenir

cielavenir commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

issue seems still there

ipython2

import mujincontrollerclientcpppy
client = mujincontrollerclientcpppy.CreateControllerClient('mujin:mujin', 'localhost')
client.UploadFile('あ.txt', 'mujin:/あ.txt')

master

ls /data/media/mujin/
%E3%81%82.txt

notEncodeFilenameWhenUploading

ls /data/media/mujin/
あ.txt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cielavenir

cielavenir commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

meanwhile let me check filename= in uri

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cielavenir cielavenir mentioned this pull request Apr 29, 2022
specify filename in UploadFileToControllerViaForm #107
Draft
@cielavenir

cielavenir commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

so let's adopt #107

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cielavenir @rdiankov @ziyan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.