GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(dashboard): resolve QA regressions by jsers · Pull Request #2481 · n9e/fe

Conversation

@jsers

@jsers jsers commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve saved bar-chart axes and variable selections when switching single/multiple modes, and keep the All option disabled after saving variable edits.
  • Resolve timeseries legend formatting per series, restore Stat precision after removing overrides, use the displayed range for BarGauge thresholds, and correct text alignment and English span-null labels.
  • Exclude *.test.tsx from production TypeScript inputs alongside *.test.ts, and complete the value-mapping integration fixture and persistence assertion with the required color field.

Review

  • Reviewed the branch changes against origin/main and the follow-up configuration/test changes using repository review rules.
  • No blocking findings were identified.

Verification

  • Original dashboard regressions: targeted Jest run passed 7 suites / 56 tests.
  • Value-mapping integration regression: targeted Jest run passed 1 suite / 4 tests after fixing the fixture and assertion.
  • Targeted TypeScript compiler API diagnostics for valueMappings.integration.test.tsx, with project ambient declarations: passed.
  • TypeScript configuration parsing confirms production root files exclude both test extensions while retaining dashboard source files.
  • Jest collection still includes valueMappings.integration.test.tsx.
  • Prettier checks and git diff --check / git diff --cached --check: passed.

Notes / Risks

  • Production configuration now excludes TSX test roots; these tests remain available to Jest. Referenced files may still be included by TypeScript through imports.
  • Browser visual QA and full build/type checks were not run, following repository instructions.
  • Passing tests emit React/Ant Design deprecation and Select value-shape warnings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jsers
fix(dashboard): resolve QA regressions
258219b
@jsers
jsers force-pushed the fix/dashboard-qa-regressions branch from 88acddc to 258219b Compare November 12, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jsers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.