GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — adding fix to skip the update of arg keys/values when an error is pre… by huacchob · Pull Request #862 · networktocode/netutils

Conversation

@huacchob

@huacchob huacchob commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

…sent and type annotation updates

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@huacchob
adding fix to skip the update of arg keys/values when an error is pre…
0489aa1 
…sent and type annotation updates
@huacchob
huacchob requested review from itdependsnetworks, jeffkala and qduk as code owners July 20, 2026 15:44
@huacchob
removing mypy ignore comment and adding changelog
8e1f961
jeffkala
jeffkala reviewed Aug 10, 2026
View reviewed changes
Comment thread netutils/nist.py


class OsPlatform(metaclass=abc.ABCMeta):
class OsPlatform(abc.ABC):

@jeffkala jeffkala Aug 10, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so largely this is the only actual change? All the mypy typing changes are not needed? Just updates based on newer floor of python version?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huacchob huacchob Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change I actually want to implement is in netutils.nist.py line 221 https://github.com/networktocode/netutils/pull/862/changes#diff-e90ca65a37a941e8f2767f35f4b6483dbccc5fb9ca85d74dcc904bb28ac7a748R221

This skips adding the "Error" key to the field_values dict.

This is the error I get when the "Error" key is present:

[12:43:55.465] There was an error in creating URLs for this Software Version. Please check the version value for Cisco cisco_ios 03.03.05SE. ERROR: CiscoIos.__init__() got an unexpected keyword argument 'Error'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffkala jeffkala jeffkala left review comments
@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner
@qduk qduk Awaiting requested review from qduk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@huacchob @jeffkala
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.