GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dns refactor [Work in progress do not merge] by jmaxxz · Pull Request #167 · node-pcap/node_pcap

Conversation

@jmaxxz

@jmaxxz jmaxxz commented May 2, 2015

Copy link
Copy Markdown
Collaborator

Refactor dns decoding.

  • Break apart various decoders
  • Simplify name decoding
  • Add specs

NOTE: At this time this pull request is not at feature parody with master. ToString functions are not as well developed. And while the name decode is simpler it is incomplete as it does not support use of pointers in dns names. This can not be merged in till both of those issues are addressed.

Sources:
https://tools.ietf.org/html/rfc1035 Section 4.1.4 has a good description of what makes a valid name
https://www.ietf.org/rfc/rfc1034.txt provides an intro to dns
SkypeIRC.cap contains several good examples of dns

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jmaxxz added 12 commits April 12, 2015 18:47
@jmaxxz
Begin refactoring of dns resource record decoder
850cddf
@jmaxxz
Spit dns decoder into multiple files
50e094d
@jmaxxz
Fix code changed in refactoring to actually work
a6804f1
@jmaxxz
Refactor toString function for dns queries
8425bae
@jmaxxz
Fix bug in query name decoding
984cd83
@jmaxxz
Create scaffold for spec of dns flags
d58eb51
@jmaxxz
Add test for dns flags
0d084fb
@jmaxxz
Add test for DnsQuery
1f3360e
@jmaxxz
Add tests for DnsResourceRecord
dc1a3b9
@jmaxxz
Add decoding of ipv4 dns resource responses
89335e9
@jmaxxz
Add support basic support for PTR IN resource records
f1796ea
@jmaxxz
Don't crash on domain names ending in a point
802e02d
@coveralls

coveralls commented May 2, 2015

Copy link
Copy Markdown

Coverage Status

Coverage increased (+4.27%) to 66.48% when pulling 802e02d on jmaxxz:dnsRefactor into 32b93f0 on mranney:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jmaxxz @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.