GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: re-enable WebID-TLS tests (tiny bug fix from 2019) by melvincarvalho · Pull Request #1842 · nodeSolidServer/node-solid-server

Conversation

@melvincarvalho

@melvincarvalho melvincarvalho commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Summary

This is a tiny bug fix (~10 lines changed) that re-enables the WebID-TLS tests that were incorrectly disabled in October 2019.

What happened

In October 2019 (PR #1333), the TLS tests were updated to properly test multiuser mode with tim.localhost and nicola.localhost. When some tests failed, they were skipped with the comment "TLS is currently broken, but is not a priority to fix".

However, the code was never broken - only the test infrastructure was incomplete:

  1. Travis CI had the hosts configured in addons.hosts
  2. When migrated to GitHub Actions in December 2020, this configuration was lost
  3. The WebID-TLS authentication code (lib/api/authn/webid-tls.mjs) has been intact and functional throughout

Changes

  • Remove describe.skip / it.skip from test/integration/acl-tls-test.mjs (5 instances)
  • Add hosts setup step to .github/workflows/ci.yml for multiuser DNS resolution

Verification

The WebID-TLS code path:

  1. lib/api/authn/webid-tls.mjs - Handler extracts certificate and verifies WebID
  2. lib/webid/lib/verify.mjs - Fetches profile and matches cert:modulus/exponent

All this code is intact. The test certificates match the test profiles (modulus verified).

Fixes #1841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@melvincarvalho
melvincarvalho force-pushed the fix/webid-tls-tests branch from 410fd55 to b4f72c5 Compare January 8, 2026 23:00
@melvincarvalho melvincarvalho mentioned this pull request Jan 8, 2026
Enable WebID-TLS integration tests (fix self-signed cert verification loop) #1841
Open
@melvincarvalho
melvincarvalho force-pushed the fix/webid-tls-tests branch 2 times, most recently from c4b6124 to 7648c61 Compare January 8, 2026 23:05
@melvincarvalho
docs: document actual reason WebID-TLS tests are skipped
42925c6 
The tests were skipped in 2019 with a misleading comment saying "TLS is
broken". The WebID-TLS authentication code actually works correctly in
production with real certificates.

The test failure is a bootstrapping issue with self-signed certs:
1. Test client connects with cert containing WebID on localhost
2. Server's webid.verify() fetches that profile URL
3. Internal fetch() rejects the self-signed cert, causing timeout

This commit replaces the misleading "TLS is broken" comment with accurate
documentation of the actual issue and potential fixes.

Related: nodeSolidServer#1841
@melvincarvalho
melvincarvalho force-pushed the fix/webid-tls-tests branch from 7648c61 to 42925c6 Compare January 8, 2026 23:08
@melvincarvalho melvincarvalho mentioned this pull request Jan 8, 2026
fix: make WebID profile fetch respect NODE_TLS_REJECT_UNAUTHORIZED in tests #1843
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable WebID-TLS integration tests (fix self-signed cert verification loop)

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@melvincarvalho
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.