GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add storage description link discovery by SarthakDudhe · Pull Request #1854 · nodeSolidServer/node-solid-server

Conversation

@SarthakDudhe

@SarthakDudhe SarthakDudhe commented May 6, 2026

Copy link
Copy Markdown

Add storageDescription Link headers for GET, HEAD, and OPTIONS requests.
Point the relation to the root storage metadata resource (/.meta).
Cover resources and containers in HTTP integration tests.

Fixes #1805.

Tests

npm run lint
npm run mocha-integration

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SarthakDudhe
Add storage description link discovery
4581242
csarven
csarven reviewed May 6, 2026
View reviewed changes

@csarven csarven left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this. I haven't run the tests but this generally looks good to me. I've run the code locally and it is referring to the expected URL for storage description resource.

Does this code assume that storage root is always at req.hostname + '/'?

I can't remember now but does NSS allow non-root path to be storage root? If so, does the code take that into account?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@csarven csarven mentioned this pull request May 6, 2026
Issue/1805 Add storage description Link discovery for Solid resources #1855
Open
@bourgeoa

bourgeoa commented May 8, 2026

Copy link
Copy Markdown
Member

I can't remember now but does NSS allow non-root path to be storage root? If so, does the code take that into account?

NSS only allow subdomain. Storage starts at root path.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csarven

csarven commented May 8, 2026

Copy link
Copy Markdown
Member

Ok, great. If you review / approve, we should merge this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bourgeoa

bourgeoa commented May 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@csarven @SarthakDudhe

From https://solidproject.org/TR/protocol#storage-description-statements
I think that root/.meta must include the triple

</> a <http://www.w3.org/ns/pim/space#Storage> .

Which is not actually the case.

If this is correct it implies to

  • update default root/.meta
  • prepare a migration script for existing servers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csarven

csarven commented May 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In NSS, it'd be (the slash for the storage resource):

</> a <http://www.w3.org/ns/pim/space#Storage> .

I don't understand why a migration script is necessary (although I understand it'd be useful to do).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bourgeoa

bourgeoa commented May 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks yes you are right I have updated above.
Why a migration ? This is because the triple is created at pod creation. On existing server you need to update all existing pods.
We add the same issue when Solid spec introduced pim:storage or solid:oidcIssuer in profile/card

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csarven

csarven commented Jul 7, 2026

Copy link
Copy Markdown
Member

@bourgeoa Could you please confirm if NSS only allows storage root to be / after hostname? If so, that should address my inquiry in my earlier comment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bourgeoa

bourgeoa commented Jul 7, 2026

Copy link
Copy Markdown
Member

NSS only allow subdomain pods.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csarven

csarven commented Jul 7, 2026

Copy link
Copy Markdown
Member

@bourgeoa Anything else remaining besides the migration script to include a pim:Storage in storage description (/.meta)? This PR only covers the storage description link discovery. Could the Storage statement be left for a separate PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bourgeoa
bourgeoa changed the base branch from main to issue-1805-storage-description August 8, 2026 16:34
@bourgeoa

bourgeoa commented Aug 18, 2026

Copy link
Copy Markdown
Member

@SarthakDudhe @csarven
what is missing is updating the templates files

  • default-templates/new-account/.meta
  • config/templates/new-account/.meta
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csarven csarven csarven left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement storage description resource discovery

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SarthakDudhe @bourgeoa @csarven
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.