GeezerVison is showing github.com — Issue/1571 account recovery when email address includes `+` by SarthakDudhe · Pull Request #1860 · nodeSolidServer/node-solid-server
Conversation
SarthakDudhe
commented
May 7, 2026
•
edited by TallTed
Loading
Uh oh!
There was an error while loading. Please reload this page.
I worked on #1571: “If you sign up with a plus sign in your email, your account can't be used or recovered” on branch issue/1571-plus-email-recovery.
The safest concrete fix here is in the recovery-email path. NSS writes the account recovery email into mailto: IRIs in account templates, then reads it back out of the root ACL during password reset. I updated account-template.mjs to encode the local part of mailbox addresses for mailto: usage, so [email protected] is stored as jon%[email protected]. I also updated account-manager.mjs to decode the stored mailto: value back to the original email when loading the recovery address.
I added focused unit coverage in account-template-test.mjs and account-manager-test.mjs for the exact + case from the issue. npx mocha test/unit/account-template-test.mjs test/unit/account-manager-test.mjs passes with 39 passing. npm run lint also passes, with the same pre-existing unrelated warning in test/integration/params-test.mjs.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
TallTed
changed the title
Issue/1571 plus email recovery
Issue/1571 account recovery when email address includes +
May 7, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.