GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove bootstrap dependency by mmustafasenoglu · Pull Request #1874 · nodeSolidServer/node-solid-server

Conversation

@mmustafasenoglu

@mmustafasenoglu mmustafasenoglu commented Aug 9, 2026

Copy link
Copy Markdown

Closes #1867

Bootstrap 3.4.1 has known vulnerabilities and NSS only uses it for basic CSS layout (grid, panels, forms, buttons, alerts) plus a single glyphicon-remove icon. This replaces the entire dependency with a lightweight custom stylesheet.

Changes:

  • common/css/solid.css: Added replacement CSS for all Bootstrap 3 classes used across templates (grid, panels, forms, buttons, alerts, progress, visibility, typography)
  • common/css/bootstrap.min.css: Deleted
  • lib/create-app.mjs: Removed bootstrap node_module route handlers
  • package.json: Removed bootstrap dependency
  • 72 template files: Dropped link to bootstrap.min.css

The glyphicon-remove icon is replaced with an inline SVG data URI, so no font files are needed either.

Tests pass (818 passing, 3 pre-existing EADDRINUSE failures).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mmustafasenoglu
Remove bootstrap dependency
e308433 
Bootstrap 3.4.1 has known vulnerabilities and NSS only uses it for basic CSS layout. This replaces the entire dependency with a lightweight custom stylesheet.

Closes nodeSolidServer#1867
Copilot AI lite review requested due to automatic review settings August 9, 2026 21:33
Copilot AI reviewed Aug 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mmustafasenoglu

mmustafasenoglu commented Aug 9, 2026

Copy link
Copy Markdown
Author

Hi @bourgeoa, sorry about that — I accidentally closed the previous PR. I've reopened it here with the same changes. The fork had been deleted so I couldn't reopen #1871 directly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove bootstrap dependency

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mmustafasenoglu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.