GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — should be using absolute URLs according to the spec · Issue #8 · nodeSolidServer/node-solid-ws

should be using absolute URLs according to the spec #8

New issue
Copy link
New issue
Copy link
Open
Open
should be using absolute URLs according to the spec#8
Copy link

Description

@michielbdejong
michielbdejong
opened on May 7, 2019
Issue body actions

https://github.com/solid/solid-spec/blob/master/api-websockets.md
So sub https://localhost:8443/public/ and not sub /public/ or sub public

Activity

  1. RubenVerborgh commented on May 7, 2019

    @RubenVerborgh
    RubenVerborgh
    on May 7, 2019
    More actions

    Agreed, but a warning for implementers: the module might not know the external URL (might be behind a proxy etc.), which is part of (for instance) NSS config.

  2. michielbdejong commented on May 7, 2019

    @michielbdejong
    michielbdejong
    on May 7, 2019
    MemberAuthor
    More actions

    Yes, in that case it should look at the X-Forwarded-Host header, I think? The LDP server probably also wants to know which absolute URLs it can consider as local.

  3. RubenVerborgh commented on May 7, 2019

    @RubenVerborgh
    RubenVerborgh
    on May 7, 2019
    More actions

    Indeed, that one and related headers (https://tools.ietf.org/html/rfc7239).
    Also theoretically need to distinguish between HTTP and HTTPS, but we should be able to safely assume the latter (although you never know in test environments).

    Trouble is that NSS will prefer its configured URL and the Host header over these, but that's probably a NSS problem then.

    Reacted by Michiel de Jong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.