GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: Refactor publishing by maxkorp · Pull Request #350 · nodegit/nodegit

Conversation

@maxkorp

@maxkorp maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator

So I've done quite a bit here.

  • First of all, we've minimized the dependency list for normal non dev installs.
  • If the install happens from the NPM registry, we clean up after ourselves (cuts size by ~50%) including some extra dependencies (takes us well over 50% savings).
  • Added the option to do a debug build using BUILD_DEBUG=1, and a shorthand npm run buildDebug
  • Moved node-webkit detection to an outside module
  • made it so generate scripts can be called on the command line, but require returns a function, rather than taking immediate effect.
  • moved all scripts out of the root directory and in to lifecyclescripts
  • prepublish step also downloads vendor deps, since those are now published.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maxkorp maxkorp changed the title Refactor publishing WIP: Refactor publishing Jan 14, 2015
@maxkorp
maxkorp force-pushed the refactor-publishing branch from e6c5819 to 7258070 Compare January 14, 2015 19:01
@maxkorp

maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator Author

So I'm trying to figure out why this fails on linux 10, something with content type headers not being set...
Definitely pretty confused.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator

👍, but bump the minor version number when you release it. If it introduces the smallest bug, it will trouble people that depends on ~0.2.4. I suggest keeping this new 0.3 release in a new branch, just to simplify life for newcomers to the project, and merge when it is all done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxkorp

maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator Author

I'm fine pushing it to an 0.3.0. Might be time for that bump soon anyways with the libgit changes from upstream.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxkorp
maxkorp force-pushed the refactor-publishing branch 5 times, most recently from 2dfad62 to 6188842 Compare January 16, 2015 18:20
@maxkorp

maxkorp commented Jan 16, 2015

Copy link
Copy Markdown
Collaborator Author

During the refactor a version check got missed, which usually caused a different version of http_parser to get pulled in for v10. That wasnt happening, causing a mismatch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxkorp
maxkorp force-pushed the refactor-publishing branch 3 times, most recently from cc3e106 to d4bbb04 Compare January 19, 2015 19:34
maxkorp added 16 commits January 19, 2015 12:51
@maxkorp
remove prepublish step
1882a99
@maxkorp
change generation scripts to work from command line but return functi…
37e2e49 
…on via require
@maxkorp
allow publishing of vendors
c8cbbf2
@maxkorp
add some new dependencies
d5ef754
@maxkorp
overhaul the rest of the build process
5764d4c 
includes cleaning of npm registry based installs and a new debug build
@maxkorp
add clean to postinstall
4d9877c
@maxkorp
remove unneeded dep
6c9da49
@maxkorp
check for npm registry was backwards
92f56af
@maxkorp
non-registry builds could trigger building twice
2e9cf11
@maxkorp
debug info
4ee7db7
@maxkorp
only fetch vendor once
4bc52ed
@maxkorp
fix http_parser in v10
e9b7026
@maxkorp
debug info
65a48c9
@maxkorp
fix the ACTUAL version of the http_parser
14e46fe
@maxkorp
start linting lifecycleScripts
9dce619
@maxkorp
fix linting in lifecyclescripts
cad078e
@maxkorp
maxkorp force-pushed the refactor-publishing branch from d4bbb04 to cad078e Compare January 19, 2015 19:52
@maxkorp

maxkorp commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator Author

Making a new PR for the 0.3 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxkorp maxkorp closed this Jan 19, 2015
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2020
[Snyk] Security upgrade node-pre-gyp from 0.6.39 to 0.9.0 contentascode/nodegit#8
Open
@jmatsushita jmatsushita mentioned this pull request Jun 29, 2022
[Snyk] Security upgrade node-pre-gyp from 0.6.39 to 0.9.0 contentascode/nodegit#16
Open
@takeratta takeratta mentioned this pull request Nov 28, 2023
[Snyk] Fix for 8 vulnerabilities takeratta/nodegit#2
Open
@jmatsushita jmatsushita mentioned this pull request Dec 19, 2023
[Snyk] Fix for 13 vulnerabilities contentascode/nodegit#20
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@maxkorp @mcollina
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.