GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pass addFile() response from cloudfiles to callback (instead of `true`) by fearphage · Pull Request #50 · nodejitsu/node-cloudfiles

Conversation

@fearphage

@fearphage fearphage commented Oct 30, 2012

Copy link
Copy Markdown

Passing true to the addFile callback causes a loss of data.

Use Case

I'd like to access the etag header in the response. The etag is an md5sum of the uploaded file. I can compare this to my local file to verify the upload was successful.

Review on Reviewable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fearphage added 2 commits October 30, 2012 16:54
@fearphage
addFile() should return the response from the server
86326c5
@fearphage
made addFile() pass the server response to the callback
aaed296
@indexzero

indexzero commented Nov 29, 2012

Copy link
Copy Markdown
Member

Sorry for the delay here! We've been waiting on all the issues / pull-requests for node-cloudfiles and node-cloudservers until we released pkgcloud: a new cross-provider unified IaaS library for node.js:

https://github.com/nodejitsu/pkgcloud
http://blog.nodejitsu.com/introducing-pkgcloud

We added a deprecation notice for this library, but would you consider reimplementing your pull-request for the Rackspace provider in pkgcloud? It would make you a HERO in my book 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fearphage @indexzero
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.