GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: default shell for alpine images by damiankoper · Pull Request #1380 · nodejs/docker-node

Conversation

@damiankoper

@damiankoper damiankoper commented Oct 26, 2020

Copy link
Copy Markdown

npm defaults shell and script-shell config settings to bash, which is not available in alpine image.
Npm 7 respects this setting and tries to call bash -c 'git rev-parse ...' while trying to install package directly from git.

Fixes #1378

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@LaurentGoderre

LaurentGoderre commented Oct 27, 2020

Copy link
Copy Markdown
Member

The change looks good but would it be possible to exclude the Yarn and signature key changes from the PR?

damiankoper reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@damiankoper
feat: default shell for alpine images
9050986
@damiankoper
damiankoper force-pushed the alpine-default-shell branch from f6fb099 to 9050986 Compare October 27, 2020 19:06
@damiankoper

damiankoper commented Oct 27, 2020

Copy link
Copy Markdown
Author

Sure. I ran ./update.sh and thought that's ok.
Ready to go.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SimenB

SimenB commented Oct 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

FWIW, I don't think it should be up to the docker image to tell npm not to "misbehave". Then again, this isn't a huge burden for us, so 🤷

/cc @nodejs/npm thoughts?

PeterDaveHello reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ruyadorno

ruyadorno commented Oct 28, 2020

Copy link
Copy Markdown
Member

Checked with the team and it does sounds like the default should be sh instead, we'll fix it soon 😊 thanks for the heads up @SimenB

SimenB reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PeterDaveHello

PeterDaveHello commented Nov 4, 2020

Copy link
Copy Markdown
Member

@ruyadorno thanks! Please let us know when it's fixed, so we can close this issue ;)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ruyadorno

ruyadorno commented Nov 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@PeterDaveHello the fix went out in the [email protected] release which has already been merged to node master and is going out in the [email protected] release: nodejs/node#35948 let me know once that's out if all related issues are solved 😊

damiankoper reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PeterDaveHello

PeterDaveHello commented Nov 4, 2020

Copy link
Copy Markdown
Member

Sure, thanks @ruyadorno

ruyadorno reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nschonni

nschonni commented Nov 5, 2020

Copy link
Copy Markdown
Member

Closing as the 15.1.0 images have been pushed to the docker hub

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nschonni nschonni closed this Nov 5, 2020
@SimenB

SimenB commented Nov 5, 2020

Copy link
Copy Markdown
Member

For reference: npm/cli#2067

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Last alpine image breaks npm install with git+ssh

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@damiankoper @LaurentGoderre @SimenB @ruyadorno @PeterDaveHello @nschonni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.