GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Node.js 18.19.0, 21.3.0 by knksmith57 · Pull Request #2002 · nodejs/docker-node

Conversation

@knksmith57

@knksmith57 knksmith57 commented Dec 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

Followed https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md

Builds images for nodejs/node#50953

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Note: it doesn't look like update.sh is correctly handling the alpine image updates due to a failing checksum fetch for 18.x

❯ ./update.sh alpine
Updating version 18...
Updating version 20...
Updating version 21...
18/bookworm/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
18/bullseye-slim/Dockerfile is already up to date!
18/bullseye/Dockerfile is already up to date!
18/buster-slim/Dockerfile is already up to date!
18/buster/Dockerfile is already up to date!
18/bookworm-slim/Dockerfile is already up to date!
20/buster/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bookworm-slim/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bullseye-slim/Dockerfile is already up to date!
20/alpine3.18/Dockerfile is already up to date!
20/buster-slim/Dockerfile is already up to date!
20/alpine3.17/Dockerfile is already up to date!
21/bookworm/Dockerfile is already up to date!
21/bookworm-slim/Dockerfile is already up to date!
21/bullseye/Dockerfile is already up to date!
21/bullseye-slim/Dockerfile is already up to date!
21/alpine3.17/Dockerfile is already up to date!
21/alpine3.18/Dockerfile is already up to date!
Done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Looks like the checksum file for 18.19.0 is missing on unofficial-builds.nodejs.org: https://unofficial-builds.nodejs.org/download/release/v18.19.0/SHASUMS256.txt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57 knksmith57 mentioned this pull request Dec 1, 2023
Release artifacts for 18.19.0 Alpine builds are missing nodejs/node#50997
Closed
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Filed nodejs/node#50997. It turns out all release artifacts for 18.19.0 for alpine are missing.

https://unofficial-builds.nodejs.org/download/release/v18.19.0/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

@richardlau has requeued the 18.19.0 release build for us 🙏: nodejs/node#50997 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57
feat: Node.js 18.19.0, 21.3.0
a118a3d 
Signed-off-by: Kyle Smith <[email protected]>
@knksmith57
knksmith57 force-pushed the version-update branch from 0267c77 to a118a3d Compare December 1, 2023 23:49
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

OK, alpine images are updated and things look good 💯

This is ready for review 🙏
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

nvm, this is obviated by #2003
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knksmith57 knksmith57 closed this Dec 1, 2023
@knksmith57
knksmith57 deleted the version-update branch December 1, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@knksmith57
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.