GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||
GeezerVison is showing github.com — chore: update messages on automated/official PRs by nschonni · Pull Request #2665 · nodejs/docker-node Conversation
Member
DescriptionAdds the pointers/messages about the Docker Image release cycle to the body of the PRs. Motivation and ContextProbably won't prevent the "why isn't this available" comments we often get, but having it in the body means it's less likely to ge folder/hidden if people come to the actual PRs to comment. Testing DetailsExample Output(if appropriate)Types of changes
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
nschonni
force-pushed
the
pr-body-updates
branch
from
efa8cba to
78941b5
Compare
MikeMcC399
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it's necessary to remove this link.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
MikeMcC399
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would have worded this a bit differently, but that's more of a style question. "If you are reading this PR soon after it has been merged, you may find that new Docker images are missing or appear broken. Check back later and see the README for background information."
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feel free to suggest the wording, I don't really feel strongly about the words I used
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to get back to this topic at a more general level in terms of how we can better inform users about progress and I'd like to involve the Docker team for this. Last week got quite hectic for lots of people in IT dealing with multiple security issues.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
nschonni
force-pushed
the
pr-body-updates
branch
from
78941b5 to
83c88bc
Compare
MikeMcC399
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll go along with this change as it puts a bit more information into users' hands. There will probably still be users who are impatient and post comments though.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |