GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — jenkins: paginate PR commits to find the latest commit by phillipj · Pull Request #153 · nodejs/github-bot

Conversation

@phillipj

@phillipj phillipj commented Oct 31, 2017

Copy link
Copy Markdown
Member

When pushing Jenkins status to a PR, we need to reference the commit SHA the inline GitHub PR status relates to.

These changes fixes a bug when handling enormous PRs with more than 100 commits (e.g. nodejs/node#9745), where we have to paginate commits results for that PR to find the last commit SHA.

Fixes #97

/cc @nodejs/github-bot

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@phillipj
jenkins: paginate PR commits to find the latest commit
70818f2 
When pushing Jenkins status to a PR, we need to reference the commit
SHA the inline GitHub PR status relates to.

These changes fixes a bug when handling enormous PRs with more than
100 commits, where we have to paginate to commits results for that PR
to find the last commit SHA.

Fixes nodejs#97
gibfahn

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@phillipj
phillipj merged commit f701303 into nodejs:master Nov 2, 2017
@phillipj
phillipj deleted the paginate-pr-commits branch November 2, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jenkins build status not visible in big PRs

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@phillipj @gibfahn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.